probe: avoid reporting the container ID as its hostname#3746
Draft
probe: avoid reporting the container ID as its hostname#3746
Conversation
If hostname isn't set on a container it defaults to a random hex number which we don't want to show in the UI.
bboreham
force-pushed
the
no-hex-hostnames
branch
from
24c40a6 to
a11e4ec
Compare
fbarl
reviewed
Feb 18, 2020
fbarl
approved these changes
Feb 18, 2020
Contributor
fbarl
left a comment
fbarl
left a comment
There was a problem hiding this comment.
Looks like a reasonable change :)
I didn't come across this before - do you have an example at hand that you paste / link to here?
Collaborator
Author
|
Example: you can see that the hostname of the container is the first 12 characters of the container ID.
|
Collaborator
Author
|
However, with this PR the second container disappears from the "containers by DNS name" view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If hostname isn't set on a container it defaults to a random hex number, which we don't want to show in the UI.